Replace `from <module> import ...` with `import <module>`
`from <module> import xyz` brought `xyz` into the namespace of the package. One then use this external function/ object without the context of its package. This is considered bad practices in Python.
`import <module>` requires user to write `<module>.xyz` when using function/object. This explicitly states that `xyz` is a function/ object within `<module>`, and not a function/ object in the current Python module.
Was completed by but JIRA wont let me keep her as assignee to close the issue so I'm assigning to myself
, Seeing as you reviewed that PR, you can probably close. Looks fine to me
, you are probably most aware about this issue as well. How can i see this is done as the PR above was aborted.
Per discussion with in https://github.com/Sage-Bionetworks/synapsePythonClient/pull/654, we will follow pipenv convention where:
for external imports, use import
if the external import contains sub-module, we will use alias in which . will be replaced with _
for synapseclient imports, we will use relative path with from . imports …