Many integration tests fails when running against stack 240.

Description

This morning, we update the dev-stack to 240. Many integration tests failed because the actual entity (from the backend) does not match with the expected entity in the integration tests. For example:


The modifiedOn field is 1 second different on each entity.
This issue holds up the development process in the client, and need to be addressed ASAP.

Environment

None

Activity

Show:
Ziming Dong
September 26, 2018, 11:50 PM

Looks like the builds for the dev branch and 1.9.0-rc branches are back to normal

Kimyen Truong
September 24, 2018, 11:47 PM

Discussed with , the tests failed because syn.store always save annotations. Saving annotations change the etag and modifiedOn.
Before refactoring syn.store, we will change syn.store to always do a syn.get and return the result of syn.get. That way, the user who is using syn.store will get the most up-to-date properties of the entity.

We evaluate that syn.store takes .6s in avg without syn.get (proposed) and takes .8s with the proposed syn.get.

Kimyen Truong
September 24, 2018, 8:41 PM

List of integration tests that failed:

  • integration.integration_test_Entity.test_Entity

  • integration.test_synapseutils_sync.test_syncFromSynapse__children_contain_non_file

  • integration.test_synapseutils_sync.test_syncFromSynapse__given_file_id

Kimyen Truong
September 24, 2018, 8:28 PM
Edited

, Thank you for the summary.
In the example (see the screenshot), there is also a new field linksTo in the returned Link. Is this field new?
Never mind, this field shows up at different location in the actual and expected values.

Fixed

Assignee

Kimyen Truong

Reporter

Kimyen Truong

Validator

Ziming Dong

Development Area

None

Release Version History

None

Slack Channel

None

Fix versions

Priority

Critical