Recursive get (sync) broken for empty folders.

Description

The logic:

is wrong as zero results will be returned for an empty folder and getting the folder will not compare correctly to a File.

Also why aren't we using synapseutils.walk here instead of replicating the code.

Environment

None

Activity

Show:
Kimyen Truong
May 15, 2018, 6:05 PM
Edited

Verified that the problem exists in the Python client 1.8.1.
Error from calling `syncFromSynapse()` on an empty folder:

For non-empty folder:

Note that the warning is very confusing:

Does anyone else think that this is confusing?

Kimyen Truong
May 15, 2018, 6:18 PM

Running `syncFromSynapse` on a project that contains an empty folder:

Larsson Omberg
May 15, 2018, 6:40 PM

Yes, I don't think we should not warn if we overwrite files in the cache. The cache should not be touched directly by the user.

Kimyen Truong
May 15, 2018, 11:25 PM
Kenneth Daily
August 17, 2018, 8:36 PM

works!

Assignee

Kimyen Truong

Reporter

Larsson Omberg

Labels

None

Validator

Kenneth Daily

Development Area

None

Release Version History

None

Fix versions

Priority

Major
Configure