support object store from client

Description

The GDC is taking over the support of Jamboree. This change will require us to support external object stores that will not generate pre-signed URLs. From the perspective of the Python client this should be relatively easy by supporting URLS with the prefix S3.

Environment

None

Activity

Show:
Ziming Dong
October 17, 2017, 12:04 AM
Edited

you should now be able to update the StroageLocationSetting using setStroageLocation() on the master branch.
The spinning wheel is caused by

Kenneth Daily
October 18, 2017, 9:24 PM

I can update the storage location now!

The only thing left from my previous comments is the parameter names for that function. We use 'entity' to set what to update in 'setProvenance', 'setAnnotations', and 'setPermissions'. I think we should continue with that instead of 'project_or_folder' which is currently used. Even if the function takes specific types, they should be consistent and give a useful error if the wrong type is given (and be documented).

Ziming Dong
October 18, 2017, 10:52 PM

It's been renamed to entity. I decided on letting the backend handle the error message about incorrect entity types since if they gave us an id as a string we'd have no idea of the type until it reached the backend anyways. This way the error messages will be consistent regardless of the type they pass to us.

Kenneth Daily
October 18, 2017, 10:57 PM

Thanks! From my view it's G2G - will close once it's marked resolved, just ping me when that's all done!

Kenneth Daily
October 20, 2017, 8:57 PM

fixed, thanks!

Assignee

Ziming Dong

Reporter

Larsson Omberg

Labels

None

Validator

Kenneth Daily

Development Area

None

Release Version History

None

Fix versions

Priority

Major
Configure