Fetching by file path fails for symbolic links

Description

When doing

synapse show /path/to/file

The test for isFile fails if /path/to/file is a symbolic link. Specifically:
isFile = os.path.isfile(entity) if isinstance(entity, basestring) else False
in syn.get()
And hence we get an ugly 500 error from Synapse when we try to get the synId "path/to/file"

Environment

None

Activity

Show:
Ziming Dong
September 12, 2017, 12:56 AM

Could you try to reproduce this again? I haven't been able to reproduce on Windows or a Mac. This issue may be referring to older code since I cant find a "isFile" variable inside of the get() method anymore.

Ziming Dong
June 14, 2017, 2:25 AM

Was not able to reproduce on Windows. symlinks probably work differently on Windows (not a windows shortcut). I will need to install a linux distro to reproduce.

Cannot Reproduce

Assignee

Ziming Dong

Reporter

Larsson Omberg

Labels

None

Validator

Larsson Omberg

Development Area

None

Release Version History

None

Slack Channel

None

Components

Fix versions

Priority

Minor