Failing tests against dev stack (329)

Description

I'm getting failures running the tests from the develop branch against dev stack (stack-329),
see http://jenkins.sagebase.org:8080/job/python-client-smoke-test-dev-against-staging/label=ubuntu-18/129/console.

Looks like updates are failing?
Traceback:

Environment

Smoke test, built from develop branch

Activity

Show:
Marco Marasca
September 27, 2020, 5:38 AM
Edited

Thanks . That would be my fault: as part of the that PR I removed the deprecated (~7 years ago) API. I did check the DW on PUT /entity/#/version/# (I checked the wrong constant) and didn’t find any record for the past 6 months which makes sense since the API I removed is /entity/#/version (without the version number path variable). We need to restore that API. Note, maybe after 7 years is not deprecated after all ?

Jordan Kiang
September 27, 2020, 5:57 AM

, so is the deprecation that the /version suffix on PUT /entity/{id} is not necessary to increment the version since the backend will automatically detect a difference and increment the version without the client forcing the increment? If so I’ll make the change in the Python client so that we can eventually retire the endpoint (but there will be the long tail of existing client deployments of course).

Marco Marasca
September 27, 2020, 6:07 AM

The (deprecated) PUT /entity/{id}/version always creates a new version. The PUT /entity/{id} has an optional parameter newVersion, that defaults to false. Even if the parameter is false a new version is automatically created when the file handle id is updated (and from next release iff the MD5 does not match, see PLFM-6429).

Xavier Schildwachter
September 29, 2020, 4:10 PM

Backend issue.

Xavier Schildwachter
September 29, 2020, 4:11 PM

Python tests passed.

Done

Assignee

Jordan Kiang

Reporter

Xavier Schildwachter

Labels

None

Validator

Xavier Schildwachter

Development Area

None

Release Version History

None

Fix versions

Affects versions

Priority

Major
Configure