Error in Python test (submission annotations)
Description
Heads up: Was running python tests against a dev stack (more precisely against cwtest stack, to generate activity), based on 316 and got the error below.
Note: I run these tests weekly against dev stack to verify there's no change on the backend that would break the client. This is like a pre-test (haven't updated dev stack yet).
Environment
python 3.6, synapseclient from main branch, backend 316.
Activity
Verified fixed from develop branch.
can you validate that the issue is resolved for you (this issue manifested in the python client integration tests which now succeed as in https://travis-ci.org/github/Sage-Bionetworks/synapsePythonClient/builds/706591739)
Fixed with https://github.com/Sage-Bionetworks/synapsePythonClient/pull/761
% nosetests tests.integration.synapseclient.test_evaluations:test_evaluations
.
----------------------------------------------------------------------
Ran 1 test in 18.666s
OK
: You describe the issue perfectly. I am pretty certain I introduced the change last week while removing some deprecated code:
https://github.com/Sage-Bionetworks/Synapse-Repository-Services/pull/4089/files#diff-feb41fb221ae44b11b6b4b13a305b876
I'm also fairly sure that clients rarely (if ever) use the annotations placed on an entity when evaluating a challenge submission. I asked Tom Yu, who does most of our work on challenges in this area and he says, "No. We do not instruct people to annotate the original file entity". So I think it's fine to proceed with your pull request and patch the released version of the Python client. I'm not worried about "breaking" any current challenges.
Thanks for diligently checking, !
@bruce, I typically run the test against the dev stack we build every week. This one just happens to run against a separate stack I created (cwtest, build off release-316) to test the CloudwatchLogs. I mentioned it so you guys don't try to repro against the dev stack (still off release-315) before I ugrade it. Sorry I was not was very clear!
