Code cleanup: in the Entity class. Remove code handling a 'annotations' key in the entity 'properties'

Description

This seems like it may be quite a lot of changes on top of cleanup I'm already doing for Annotations and EntityBundles so I've created a separate issue for it.

There is a relic from when we used to include URIs as a part of the Entity's properties (e.g. file_entity.properties.annotations had a value of '/repo/v1/entity/syn1234/annotations', which was returned from the backend).

Since we also include user-specified Entity annotations(as a dict) in the constructor, we have snippets of code in the Entity class that handle cases where the annotations dict got erroneously was passed into the properties object.

None of this is necessary anymore since we don't return URIs from the backend anymore

some examples of code that needs to be removed/refactored:
https://github.com/Sage-Bionetworks/synapsePythonClient/blob/8aa52162fbf6b8d9155b9542132a75c31e4201bc/synapseclient/entity.py#L239

https://github.com/Sage-Bionetworks/synapsePythonClient/blob/8aa52162fbf6b8d9155b9542132a75c31e4201bc/synapseclient/entity.py#L249

Environment

None
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Jordan Kiang

Reporter

Ziming Dong

Validator

Ziming Dong