UI changes for profile verification

Description

From the changes of we need to make sure that:

  • The user cannot re-upload previously submitted files when re-submitting (this should automatically fix itself as they are not returned if the status is not SUBMITTED and will be deleted anyway after approval/rejection).

  • The ACT can add a note when approving, rejecting or suspending. A note is tied to the state of a submission and cannot be updated (at the moment) and not to the submission itself.

  • Have a way for the ACT to read the notes of a submission (e.g. a button near a submission that opens a modal with all the notes for each state?)

  • Potentially have an indication that the files were removed when a submission is not in the SUBMITTED state (e.g. in the evidence column?)

Environment

None

Activity

Show:
Jay Hodgson
January 8, 2020, 10:05 PM

Thanks for the review!

I think there are a couple of advantages to keeping the Confirmation Dialog separate from the Rejection Dialog:

  1. Consistent Confirmation Dialog for all state changes (suspend, reject, or approve).

  2. Keeps the Reject Message (user facing) and ACT Note (ACT internal only) separate, so ACT is less likely to make a mistake (meant to send the user the note! Or meant for the reason to stay within the ACT!).

Agree that it would be more streamlined to have the ACT note in the Reject Dialog, but I’d like to try this other approach first.

Xavier Schildwachter
January 15, 2020, 6:16 PM
Edited

I think there's a problem with the dlg presented to ACT after suspending (or rejecting I guess) user.
See:


I'm ACT user, just suspended a user but the button says Resubmit, like I am the user.
Button is inactive, just needs to be hidden.

Xavier Schildwachter
January 15, 2020, 6:36 PM

Repro:

  • login as ACT

  • filter on a user

  • click More Info on any state for that user
    ==> the red part should not be displayed
    ==> the Resubmit button should not be displayed

Note: last state looks OK (it does not display red msg and has correct 'Suspend' action)

Jay Hodgson
January 15, 2020, 8:35 PM

Agree that Resubmit button should not be shown if on the ACT (if in suspended or rejected state), but I think the red part should be displayed (the public reason why the submission was rejected/suspended). The label text is not quite right for ACT in this case, but I think the data needs to be shown.

Xavier Schildwachter
January 16, 2020, 1:03 AM

Verified fixed 293.0/293.0-15x.

Fixed

Assignee

Jay Hodgson

Reporter

Marco Marasca

Labels

None

Validator

Xavier Schildwachter

Development Area

None

Release Version History

None

Sprint

None

Fix versions

Priority

Major
Configure