inconsistent card header link behavior
Hey Stockard, I chatted about this a bit with and - tagging them here in case they have input.
The behavior of the card header links is different based on context. Jay recently pushed a change to staging that changed the header link behavior for Organization cards, so I'm going to talk about the behavior as it's currently reflected on staging.nf.synapse.org.
The Organization cards (https://staging.nf.synapse.org/#Our%20Partners) have a header link that goes to the Org website, and a button that goes to the Org detail page. (on production, the header link goes to the Org detail page, and no button).
The Initiative cards (https://staging.nf.synapse.org/Explore/Initiatives) have the same behavior - header link to external url, button to detail page.
The Study cards (https://staging.nf.synapse.org/Explore/Studies) have a header link that goes to the Details page and no external link.
Personally, I prefer the header link to go to the Details page in all three cases, but then we run into this issue where the card, when used as the header of the details page, either links to something different (like an external url) or self-links (i think this was the behavior a year or more ago now).
As a "superuser" of the portal who mainly looks at Study detail pages I was a little surprised to click a header of the initative/org pages and get taken to an external location. But it may be that there are not many others out there with a predefined expectation of where that link should go.
All that is to say is that I think the behavior should be consistent across card types, but I'm not sure what the solution is to make that happen.
The link color is correct today. It's only when I remove the link configuration that the color of the title text is wrong (when being shown as a Header card).
I believe the link color got fixed based on what I saw when I selected the Organizations link above, correct me if I’m wrong .
I agree that it would be my preference to continue to mimic card behavior – of Headers = links within the portal and Visit Website = external website, and where Headers are first, and Visit Website CTAs are secondary.
I can’t say I love the look of the unlinked black text on dark blue, either, so that makes me in favor of a new ticket for a fix, too.
Unless, can we think of anywhere else the link could/would go within the portal once they’ve reached an Org Detail page, ? I can’t think of anything, but maybe you can? That’s my only possible idea for a fix that doesn’t require another ticket.
I’d say new ticket as well since we’ll also need to add a way to go to the website. Good catch .
: Nice catch. The header card currently doesn’t have this ctaCardLink functionality, so I’d need to add it there too. And when we don’t provide a title link when it’s a header, the color is wrong. So it’s definitely worthy of another ticket if it needs to be changed.