Portals Card Iconography - data type icons

Description

This refers to this design: https://www.figma.com/file/Xa96A0YZwkCpMxLdl2egu6/Study-Iconography?node-id=0%3A1

I guess there are two ways we could bring this information into these cards: query on the Portal - Files table that looks something like (select distinct dataType where studyId = syn12345), or just create a stringList column in the Portal - Studies table to store the dataTypes. I assume the latter would be much faster, but what do you think?

Environment

None

Activity

Show:
Robert Allaway
February 26, 2021, 10:20 PM

LGTM - thank you Emma and Stockard!

Emma Mills
February 24, 2021, 6:55 PM

Thank you for the clarification, . The issue is fixed on staging.

Stockard Simon
February 24, 2021, 5:46 PM

Sorry if I miscommunicated. The issue isn’t with the icon itself but rather an extra circle is appearing. I have circled it in the attachment.

 

Emma Mills
February 24, 2021, 12:46 AM

Hi , all icons have the same size of circle background. But the gene expression svg especially seems to be larger than the others and some svgs are not quite centered. We discussed that the gene expression icon was too small and it’s hard to see the details. I think now we may need to scale it down a bit if this affects the space within the circle and therefore makes the circle appear smaller.

If a svg is perfectly centered and scaled the same, it should look like the reload and check icons below. But the “camera”, “gene expression” and “other” icons are slightly off from the center. I created borders around the icons so you can see the alignment. Is it possible to fix these issues in the svg?

Robert Allaway
February 24, 2021, 12:26 AM

II missed those small dots, good catch ! Otherwise, it looks good to me!

I guess they are the Genomic Variants icon based on the tooltip.

Fixed

Assignee

Emma Mills

Reporter

Robert Allaway

Validator

Robert Allaway

Priority

Major

Labels

None

Development Area

Portals

Sprint

None

Release Version History

None

Story Points

None

Epic Link

None

Slack Channel

None