Evaluation Status is supposed to be deprecated?

Description

discovered that we are still able to submit to Evaluations that are in the CLOSED and COMPLETED state.

According to PLFM-2269, Evaluation Status was supposed to be deprecated, but it was still displayed in the old Evaluation UI, which then made its way into the newly designed Evaluation UI.

My question is how do we plan to handle EvaluationStatus going forward? Do we remove it from being displayed or is it still being used for some other purpose?

I also suggest we add a deprecated option in our schema-to-pojo so deprecated fields can be displayed differently or not at all.

Environment

None

Activity

Show:
Xavier Schildwachter
March 5, 2021, 6:27 AM
Ziming Dong
February 27, 2021, 2:07 AM

On the portals side, I believe it should be removed immediately to avoid any further confusion to users (). We can handle it later on the back-end since it's just being passed around w/ out being used anywhere.

Ziming Dong
February 27, 2021, 1:51 AM

Sure

Bruce Hoff
February 27, 2021, 12:54 AM
Edited

It's supposed to be deprecated/removed. May I put this in your backlog?

Ziming Dong
February 26, 2021, 11:43 PM

I was only able to discover after reverse searching the commit revision and matching it w/ a github issue after seeing this line. I think it's the only indication of deprecation that I've found https://github.com/brucehoff/Synapse-Repository-Services/blob/43887829c7708462bf9b0bd34d4fc1b8f4611a1c/services/repository-managers/src/test/java/org/sagebionetworks/evaluation/manager/SubmissionManagerTest.java#L220

Fixed

Assignee

Ziming Dong

Reporter

Ziming Dong

Validator

Bruce Hoff

Priority

Critical

Labels

None

Development Area

None

Sprint

None

Fix versions

Release Version History

None

Story Points

None

Epic Link

None

Slack Channel

None