Add additional "default columns" when using Tables/Folders in views

Description

Currently, there's a difference between the default columns used in views depending on entity type – this is sensible because (for example) Tables don't have fileHandles, and Folders don't have currentVersions. However, there are a few columns that should probably be available for all entity types, not just files.

Please add these columns to BASIC_ENTITY_DEAFULT_COLUMNS (if possible) so that Tables and Folders get them in the "Add Default View Columns" feature:

  • EntityField.type

  • EntityField.parentId

  • EntityField.benefactorId

  • EntityField.projectId

Do NOT add to BASIC_ENTITY_DEAFULT_COLUMNS + rationale

  • EntityField.dataFileHandleId - Tables and Folders don't have dataFileHandleId info

  • EntityField.currentVersion - Tables and Folders don't have currentVersion info (but this may change later if Tables have versions eventually)

Reference:https://github.com/Sage-Bionetworks/Synapse-Repository-Services/blob/060c511d7aa5aed42259e01d01c76102bf238883/services/repository-managers/src/main/java/org/sagebionetworks/repo/manager/table/TableManagerSupportImpl.java#L69

Also side note: there's a typo in "DEFAULT" there, only in BASIC_ENTITY_DEAFULT_COLUMNS and not in FILE_VIEW_DEFAULT_COLUMNS. If we can fix that while we are in there, great.

See first comment because I'm not totally sure we should even have different defaults here, if the non-relevant columns end up with empty/null data anyway. ???

Environment

None

Assignee

John Hill

Reporter

Meredith Slota

Labels

None

Validator

Xavier Schildwachter

Development Area

None

Release Version History

None

Components

Priority

Major
Configure